Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable all jobs for macOS and Windows #2750

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 17, 2024

Summary

This PR disables all CI Jobs for macOS and Windows, to reduce GitHub Cost. Details here: apache/nuttx#14376

Impact

CI Jobs for macOS and Windows will no longer run, until we find a way to manage their costs.

Testing

We tested the skipping of macOS and Windows jobs: https://github.com/lupyuen5/label-nuttx/actions/runs/11379543159

This PR disables all CI Jobs for macOS and Windows, to reduce GitHub Cost. Details here: apache/nuttx#14376
@nuttxpr
Copy link

nuttxpr commented Oct 17, 2024

[Experimental Bot, please feedback here]

Yes, this PR seems to meet the NuttX requirements.

Here's a breakdown:

  • Summary: Clear explanation of the change (disabling CI jobs for macOS and Windows) and its purpose (cost reduction). The related issue is linked.
  • Impact: The impact on CI is clearly stated. While the PR doesn't directly change user-facing code, it impacts the project by reducing testing coverage. It acknowledges this trade-off.
  • Testing: Evidence of testing the CI job skipping is provided.

Suggestions:

  • Impact:
    • You could clarify if disabling these jobs impacts the official supported status of macOS and Windows.
    • Briefly mention the potential risks of reduced testing on these platforms (e.g., potential for regressions going unnoticed).
  • Testing:
    • While you provide a link, consider including a brief snippet of the relevant log output within the PR description for easier review.

Overall: The PR addresses the requirements well. The suggestions above could further improve clarity and transparency.

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Oct 17, 2024

I think it's acceptable to disable macOS and Windows on apps side, since it's enough to keep nuttx side, so let's merge it.

@xiaoxiang781216 xiaoxiang781216 merged commit 4b8375e into apache:master Oct 17, 2024
36 checks passed
@lupyuen
Copy link
Member Author

lupyuen commented Oct 17, 2024

@xiaoxiang781216 Unfortunately without disabling macOS and Windows jobs in the nuttx repo, we won't know exactly how much they contribute to the 1 million GitHub Minutes that we are consuming every week. The report isn't broken down by repos. (Also I'm preparing a new PR for arch.yml, might be messy now that they have diverged)

@jerpelea Just letting you we might still exceed the ASF Quota for GitHub Minutes, since macOS and Windows jobs are still running. There's a chance that ASF may shutdown our CI in 2 weeks.

Screenshot 2024-10-17 at 11 26 42 PM

@cederom
Copy link

cederom commented Oct 17, 2024

I think its acceptable to disable heaviest works and most costly runners to measure the difference or we loose all CI.

It would be nice to have someone from Apache Infra to help us sort things out.

@cederom
Copy link

cederom commented Oct 17, 2024

I have asked Apache Infra to support. We may not have optimal results without their help / feedback.

@lupyuen
Copy link
Member Author

lupyuen commented Oct 17, 2024

Thanks Tomek! Actually I wonder if we should ask ASF for a 4-week extension. This is a terrible terrible period for all of us: Alin is busy with NuttX Release, Xiao Xiang is busy with Xiaomi Release, and I'm still hacking so many things to cut GitHub Cost. I fear that things might break if we're not careful in these two weeks.

@cederom
Copy link

cederom commented Oct 17, 2024

NuttX is really extremely complex project, considering we enable cross platform builds from Linux, BSD, macOS, Windows to tens of different architecutres and over 1000 different devices, with different sensors and different apps, we need to test before merging to master. Even processing of hundreds of PRs per month is challenging and I help however I can.

But without good testing we may get to a point where fixing stuff will be too expensive if possible at all :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[URGENT] Reducing our usage of GitHub Runners
4 participants