Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake:replace custom_patch_target with PATCH_COMMAND #1993

Merged
merged 1 commit into from
Aug 24, 2023
Merged

cmake:replace custom_patch_target with PATCH_COMMAND #1993

merged 1 commit into from
Aug 24, 2023

Conversation

xuxin930
Copy link
Contributor

Summary

this patch is another part of this issue apache/nuttx#10241

  • delete the .git condition that cause duplication of fetching stage.
  • replace custom_patch_target with PATCH_COMMAND.
  • remove custom_patch_target dependencies.
  • when fetch a lib during cmake configure phase,it will download into /cmake-build-dir/_dep/lib_src/ directory.
    every time the build directory is deleted,the download will be repeated. this patch also fixes these problem.

related to:apache/nuttx#10379

Impact

Testing

fetch for the first time and compile repeated

@xuxin930 xuxin930 mentioned this pull request Aug 24, 2023
Merged
@raiden00pl raiden00pl merged commit a091b91 into apache:master Aug 24, 2023
25 checks passed
@raiden00pl raiden00pl mentioned this pull request Aug 24, 2023
Closed
@xuxin930 xuxin930 deleted the cmake-patch-command branch October 17, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@raiden00pl raiden00pl raiden00pl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuxin930 @raiden00pl @xiaoxiang781216