Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable newt test on Mac #3332

Merged
merged 3 commits into from
Oct 30, 2024
Merged

ci: Enable newt test on Mac #3332

merged 3 commits into from
Oct 30, 2024

Conversation

sjanc
Copy link
Contributor

@sjanc sjanc commented Oct 30, 2024

We properly support 64bit in native target now so those can be re-enabled.

We properly support 64bit in native target now so those can be
re-enabled.
Enabling -Wsingle-bit-bitfield-constant-conversion compains.
repos/apache-mynewt-core/encoding/json/src/json_encode.c:187:27: error:
    implicit truncation from 'int' to a one-bit wide bit-field changes
    value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
562
    encoder->je_wr_commas = 1;
563
                          ^ ~
564
repos/apache-mynewt-core/encoding/json/src/json_encode.c:199:27: error:
    implicit truncation from 'int' to a one-bit wide bit-field changes
    value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
565
    encoder->je_wr_commas = 1;
566
                          ^ ~
567
repos/apache-mynewt-core/encoding/json/src/json_encode.c:233:27: error:
    implicit truncation from 'int' to a one-bit wide bit-field changes
    value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
568
    encoder->je_wr_commas = 1;
569
                          ^ ~
570
repos/apache-mynewt-core/encoding/json/src/json_encode.c:244:27: error:
    implicit truncation from 'int' to a one-bit wide bit-field changes
    value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
571
    encoder->je_wr_commas = 1;
572
                          ^ ~
Removed unused variable

repos/apache-mynewt-core/util/cbmem/selftest/src/testcases/
    cbmem_test_case_3.c:29:9: error: variable 'i' set but not
    used [-Werror,-Wunused-but-set-variable]
4941
    int i;
4942
        ^
4943
1 error generated.
@sjanc sjanc merged commit f860739 into apache:master Oct 30, 2024
20 checks passed
@sjanc sjanc deleted the ci_mac branch October 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants