util/stream: Add pumping functions #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
reviewed
Jun 10, 2024
hw/drivers/i2s/src/i2s_stream.c
Outdated
| } | ||
| sample_count = count / i2s->sample_size_in_bytes; | ||
|
|
||
| while (count) { |
There was a problem hiding this comment.
this looks bit odd since count is never modified inside loop
There was a problem hiding this comment.
loop was not needed and now is removed it could be replaced with if
| /* Both stream don't provide pump functions, use local buffer for pumping data */ | ||
| uint8_t buf[16]; | ||
| pumped = 0; | ||
| while (count) { |
This extends in_stream and out_stream to provide pumping functions Additionally stream_pump() function is added to allow easy pumping data between streams. Signed-off-by: Jerzy Kasenberg <[email protected]>
Code provides wrapper to use i2s with streaming API Signed-off-by: Jerzy Kasenberg <[email protected]>
kasjer
force-pushed
the
kasjer/stream-pump
branch
from
1c97436
to
f93908e
Compare
sjanc
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends in_stream and out_stream to provide pumping
functions
Additionally stream_pump() function is added to allow easy
pumping data between streams.
Signed-off-by: Jerzy Kasenberg [email protected]