Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/os/src: replace SYS_ by OS_ errorcodes #2603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjmolinas
Copy link
Contributor

This PR uses the correct error code macros for the file. This is useful to avoid redefining MACROS when only mynewt-core/kernel/os is being imported in an external project.

@fjmolinas
Copy link
Contributor Author

fjmolinas commented May 27, 2021

Ah I didn't realize its actually matching what is described in the API because OS_E% are non-negative while SYS_E% are. Since this would mean an API change this is not a small change anymore, and maybe not worth it, let me know if its of interest

@kasjer kasjer requested review from ccollins476ad and wes3 May 27, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant