[MNG-8331] Mix of the two fixes

Don't do anything if not needed. --- https://issues.apache.org/jira/browse/MNG-8331
apache · Oct 19, 2024 · 565dfb0 · 565dfb0
1 parent f4eeca2
commit 565dfb0
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
@@ -564,8 +564,10 @@ public void mergeRepositories(List<Repository> toAdd, boolean replace) {
  // Infer inner reactor dependencies version
  //
  Model transformFileToRaw(Model model) {
- List<Dependency> newDeps = new ArrayList<>();
- boolean modified = false;
+ if (model.getDependencies().isEmpty()) {
+ return model;
+ }
+ List<Dependency> newDeps = new ArrayList<>(model.getDependencies().size());
  for (Dependency dep : model.getDependencies()) {
  if (dep.getVersion() == null) {
  Dependency.Builder depBuilder = null;
@@ -591,13 +593,14 @@ Model transformFileToRaw(Model model) {
  }
  if (depBuilder != null) {
  newDeps.add(depBuilder.build());
- modified = true;
  } else {
  newDeps.add(dep);
  }
+ } else {
+ newDeps.add(dep);
  }
  }
- return modified ? model.withDependencies(newDeps) : model;
+ return model.withDependencies(newDeps);
  }
 
  String replaceCiFriendlyVersion(Map<String, String> properties, String version) {