Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2205] Use maven-plugin-report-plugin only in plugins modules #681

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

slawekjaranowski
Copy link
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This somewhat intersects with: a540ef4

Can you double-check? It should not be in build, but reporting only.

@slawekjaranowski
Copy link
Member Author

This somewhat intersects with: a540ef4

Can you double-check? It should not be in build, but reporting only.

Yes.

maven-plugin-report-plugin - should be used in reporting but only in maven-plugin in other module type has no sens

We had definition for old report in *-plugins modules - it is in reporting sections and I fixing it

@slawekjaranowski
Copy link
Member Author

After GitHub finish build we can download site from build artifacts and we can check.

@michael-o michael-o self-requested a review October 31, 2023 09:40
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the open questoin is resolved, this is good to merge.

@slawekjaranowski
Copy link
Member Author

one build failed on jenkins ... timeout

@slawekjaranowski slawekjaranowski merged commit dd2fcfd into master Oct 31, 2023
23 of 26 checks passed
@slawekjaranowski slawekjaranowski deleted the SUREFIRE-2205-fix2 branch October 31, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants