Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-4077 Back memory-app with Lucene #2464

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vttranlina
Copy link
Contributor

@quantranhong1999
Copy link
Contributor

Expecting actual throwable to be an instance of:
  java.lang.RuntimeException
but was:
  org.apache.james.StartUpChecksPerformer$StartUpChecksException: StartUpChecks got bad results: CheckResult{name=MailboxCapabilitiesForJMAP, resultType=BAD, description=Optional[Attachment Search support in MailboxManager is required by JMAP Module,Attachment file name Search support in MailboxManager is required by JMAP Module]}

seems related

@vttranlina
Copy link
Contributor Author

a bit long explain here
JMAP StartUpChecksPerformer require MessageSearchIndex support capability:

SearchCapabilities.AttachmentFileName,
SearchCapabilities.Attachment

But the reality LuceneMessageSearchIndex does not support it now, (we already have another ticket for it)
If we still try to add new capabilies for LuceneMessageSearchIndex (for pass StartUpChecksPerformer),
then another test will fail
eg:

ERROR] Errors: 
[ERROR]   LuceneMessageSearchIndexTest>AbstractMessageSearchIndexTest.searchShouldRetrieveMailByAttachmentFileName:1633 » UnsupportedSearch
[ERROR]   LuceneMessageSearchIndexTest>AbstractMessageSearchIndexTest.searchWithPDFAttachmentShouldReturnMailsWhenAttachmentContentMatches:1482 » UnsupportedSearch
[ERROR]   LuceneMessageSearchIndexTest>AbstractMessageSearchIndexTest.searchWithTextAttachmentShouldNotMatchMessageBody:1458 » UnsupportedSearch
[ERROR]   LuceneMessageSearchIndexTest>AbstractMessageSearchIndexTest.searchWithTextAttachmentShouldReturnMailsWhenAttachmentContentMatches:1443 » UnsupportedSearch

@vttranlina vttranlina force-pushed the JAMES-4077_Lucene_Memory_app_binding branch from 546e51b to eaff174 Compare October 24, 2024 02:58
@vttranlina
Copy link
Contributor Author

Not simple as my thought (just guice binding done)
a lot of test case for email query (memory test) failed, related to Lucense search
org.apache.james.jmap.rfc8621.memory.MemoryEmailQueryMethodNoViewTest

listMailsBySystemKeywordShouldReturnOnlyMailsWithThisSystemKeyword(Flags, String, GuiceJamesServer)
[5] keywordFlag=$Forwarded, keywordName=$Forwarded
ccShouldFilterResultsWhenAddress(GuiceJamesServer)
toShouldFilterResultsWhenAddress(GuiceJamesServer)
listMailsNotBySystemKeywordShouldReturnOnlyMailsWithoutThisSystemKeyword(Flags, String, GuiceJamesServer)
bccShouldFilterResultsWhenAddress(GuiceJamesServer)
emailQueryShouldSupportTextFilterForTextBody(GuiceJamesServer)
emailQueryShouldSupportTextFilterForHeaders(GuiceJamesServer)
emailQueryShouldSupportTextFilterForHtmlBody(GuiceJamesServer)
emailQueryFilterByTextShouldIncludeAttachmentName(GuiceJamesServer)
emailQueryShouldSupportTextFilterForMultipartMessage(GuiceJamesServer)
fromShouldFilterResultsWhenAddress(GuiceJamesServer)
bodyFilterShouldMatchTextPlainOnAttachmentsFileName(GuiceJamesServer)
bodyFilterShouldMatchTextPlainOnAttachmentsContent(GuiceJamesServer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SearchSnippet] Guice binding - Back memory-app with Lucene
5 participants