Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace field injection with injection by constructor #1558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace field injection with injection by constructor #1558

wants to merge 3 commits into from

Conversation

mbaechler
Copy link
Member

No description provided.

@chibenwa
Copy link
Contributor 

21:36:27,747 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project james-server-protocols-library: You have 2 Checkstyle violations. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project james-server-protocols-library: You have 2 Checkstyle violations.

@Arsnael
Copy link
Contributor

Arsnael commented Nov 27, 2023

Lots of related test failures: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1558/5/testReport/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arsnael Arsnael Arsnael approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbaechler @chibenwa @Arsnael