Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] feat(docs): Add documents for the two bufferSize configs. #2213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lwllvyb
Copy link
Contributor

@lwllvyb lwllvyb commented Oct 21, 2024

What changes were proposed in this pull request?

Add documents for the two bufferSize configs in server_guide.md.

Why are the changes needed?

Fix: #2209

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested locally.

@jerqi
Copy link
Contributor

jerqi commented Oct 21, 2024

Maybe this could be used for HDFS, too.

@lwllvyb
Copy link
Contributor Author

lwllvyb commented Oct 21, 2024

Maybe this could be used for HDFS, too.

Thanks for your suggestion. I will update this PR.
and I will add a new PR to handle with the HDFS. #2216

Copy link

github-actions bot commented Oct 21, 2024

Test Results

 2 926 files  +22   2 926 suites  +22   6h 16m 24s ⏱️ + 15m 13s
 1 049 tests ± 0   1 047 ✅ + 1   2 💤 ±0  0 ❌  - 1 
13 045 runs  +51  13 015 ✅ +52  30 💤 ±0  0 ❌  - 1 

Results for commit 2c34ed7. ± Comparison against base commit 3a35b0f.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.28%. Comparing base (9f8951f) to head (8b39960).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2213      +/-   ##
============================================
+ Coverage     52.35%   53.28%   +0.93%     
- Complexity     2815     3213     +398     
============================================
  Files           452      480      +28     
  Lines         21217    26060    +4843     
  Branches       1950     2463     +513     
============================================
+ Hits          11108    13887    +2779     
- Misses         9401    11267    +1866     
- Partials        708      906     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support config buffer size for LocalFileWriter
3 participants