Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2198]fix(server) reduce the redundant appId info for partitionKey in Abstr… #2199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lwllvyb
Copy link
Contributor

@lwllvyb lwllvyb commented Oct 18, 2024

What changes were proposed in this pull request?

There are three private variables in AbstractStorage that use partitionKey as the key for the internal Map.
PartitionKey uses the redundant appId info which is already the first key of the three private variables .

Why are the changes needed?

Fix: #2198

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tested locally

Copy link

Test Results

 2 926 files  +31   2 926 suites  +31   5h 59m 6s ⏱️ +46s
 1 043 tests ± 0   1 041 ✅ + 1   2 💤 ±0  0 ❌  - 1 
13 033 runs  +60  13 003 ✅ +61  30 💤 ±0  0 ❌  - 1 

Results for commit 5609224. ± Comparison against base commit 9f8951f.

@lwllvyb
Copy link
Contributor Author

lwllvyb commented Oct 21, 2024

Ping @jerqi @zuston @zhengchenyu @maobaolong

@lwllvyb lwllvyb changed the title fix[server] reduce the redundant appId info for partitionKey in Abstr… [#2198]fix(server) reduce the redundant appId info for partitionKey in Abstr… Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] reduce the redundant appId info for partitionKey in AbstractStorage
1 participant