remoteip: add option to enable PROXY proto for specific clients only #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a config directive which is effectively the opposite of the existing
RemoteIPProxyProtocolExceptions(reusing the code already in place for that). It allows PROXY protocol to be enabled for only a specific set of IPs, which can be useful for example when a webserver is both directly accessible to clients and also behind a reverse proxy.I've been using this for IPv6-only webservers where IPv6 clients connect directly but IPv4 clients go through a reverse proxy. I believe this also addresses part of bug https://bz.apache.org/bugzilla/show_bug.cgi?id=64433 which describes a similar use case.