Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ-69203: backport to 2.4.x #470

Open
wants to merge 5 commits into
base: 2.4.x
Choose a base branch
from
Open

BZ-69203: backport to 2.4.x #470

wants to merge 5 commits into from

Commits on Oct 10, 2024

  1. mod_proxy_fcgi: Don't re-encode SCRIPT_FILENAME. PR 69203 

    Before r1918550 (r1918559 in 2.4.60), "SetHandler proxy:..." configurations
did not pass through proxy_fixup() hence the proxy_canon_handler hooks, leaving
fcgi's SCRIPT_FILENAME environment variable (from r->filename) decoded, or more
exactly not re-encoded.

We still want to call ap_proxy_canon_url() for "fcgi:" to handle/strip the UDS
"unix:" case and check that r->filename is valid and contains no controls, but
proxy_fcgi_canon() will not ap_proxy_canonenc_ex() thus re-encode anymore.

Note that this will do the same for "ProxyPass fcgi:...", there is no reason
that using SetHandler or ProxyPass don't result in the same thing. If an opt
in/out makes sense we should probably look at ProxyFCGIBackendType.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919620 13f79535-47bb-0310-9956-ffa450edef68
    @ylavic
    ylavic committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    690d14b View commit details
    Browse the repository at this point in the history

  2. Follow up to r1919620: CHANGES entry indent. 

    git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919621 13f79535-47bb-0310-9956-ffa450edef68
    @ylavic
    ylavic committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b8b45e0 View commit details
    Browse the repository at this point in the history

  3. Follow up to r1919620: init path after "proxy:" is skipped. 

    git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919623 13f79535-47bb-0310-9956-ffa450edef68
    @ylavic
    ylavic committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fed3dde View commit details
    Browse the repository at this point in the history

  4. Follow up to r1919620: Restore r->filename re-encoding for ProxyPass … 

    …URLs.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1919628 13f79535-47bb-0310-9956-ffa450edef68
    @ylavic
    ylavic committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d4f6ad9 View commit details
    Browse the repository at this point in the history

  5. mod_proxy_fgci: Follow up to r1919628: Simplify. 

    Variable from_handler is used once so axe it.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1921237 13f79535-47bb-0310-9956-ffa450edef68
    @ylavic
    ylavic committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    07279f7 View commit details
    Browse the repository at this point in the history