[#5359] fix(ob-catalog): fix ob catalog default value parse error #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuanoOo could you plz help to review, thx~ |
jerryshao
approved these changes
Oct 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
) ### What changes were proposed in this pull request? fix ob catalog default value parse error ### Why are the changes needed? For OceanBase catalog, the `IS_GENERATEDCOLUMN` value of the column ResultSet is set to `NO`, which is causing `isExpression` to be false and leading to a parse error. Fix: #5359 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix ob catalog default value parse error
Why are the changes needed?
For OceanBase catalog, the
IS_GENERATEDCOLUMNvalue of the column ResultSet is set toNO, which is causingisExpressionto be false and leading to a parse error.Fix: #5359
Does this PR introduce any user-facing change?
no
How was this patch tested?
tests added