[#5355] export Paimon jdbc user and password to properites #5376
Conversation
|
@mchades please help to review, thanks |
| @@ -128,13 +128,13 @@ public class PaimonCatalogPropertiesMetadata extends BaseCatalogPropertiesMetada | |||
| "Gravitino Paimon catalog jdbc user", | |||
| false /* immutable */, | |||
| null /* defaultValue */, | |||
| true /* hidden */), | |||
| false /* hidden */), | |||
There was a problem hiding this comment.
Is there any test to cover this change?
There was a problem hiding this comment.
no, is it nessecery to add the specific test for Paimon JDBC catalog hidden properties?
There was a problem hiding this comment.
Is there a Paimon-JDBC catalog IT? If so, it would be easy to add the properties assert tests. Otherwise, we should supplement the IT.
There was a problem hiding this comment.
Not the mater of easy or not, I think there is no need to add this to IT, since it's minor changes
There was a problem hiding this comment.
|
should we mask the jdbc user and password on the gravitino ui? |
I think need. @LauraXia123 cc |
the password is masked on ui
|
### What changes were proposed in this pull request? export paimon jdbc user and password to properites ### Why are the changes needed? Fix: #5355 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing IT
What changes were proposed in this pull request?
export paimon jdbc user and password to properites
Why are the changes needed?
Fix: #5355
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing IT