[#3150] fix(doris-catalog): Ignore unknown table properties for Doris catalog. #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's a bug, If user set a properties which Doris doesn't support, throw an exception is more clear than remove the property. Besides it's hard to maintenance the supported properties for different Doris versions and especially consider for the compatibility to Starrocks. |
|
After a discussion with @FANNG1 , It seems that this is not an issue. I will close this PR and related issue temporarily and feel free to open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add supported table properties for Doris catalog and ignore all unknown properties.
Why are the changes needed?
Doris does not support unknown table properties.
Fix: #3150
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
IT