Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5306][Improvement] Some JDBC catalog properties should be defined as required #5337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[#5306][Improvement] Some JDBC catalog properties should be defined as required #5337

wants to merge 2 commits into from
+12 −6

Conversation

lsyulong
Copy link
Contributor

What changes were proposed in this pull request?

[#5306][Improvement] Some JDBC catalog properties should be defined as required

Why are the changes needed?

Fix: #5306

Does this PR introduce any user-facing change?

change some JDBC catalog properties

How was this patch tested?

No

mchades
mchades reviewed Oct 29, 2024
View reviewed changes
...bc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
JdbcConfig.JDBC_DRIVER.getKey(),
JdbcConfig.JDBC_DRIVER.getDoc(),
true /* required */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you plz add tests to cover the changes?

@mchades
Copy link
Contributor

mchades commented Oct 30, 2024 •
edited
Loading

Run ./gradlew :catalogs:catalog-jdbc-common:spotlessApply to fix code style

@lsyulong
Copy link
Contributor Author

Run './gradlew :catalogs:catalog-jdbc-common:spotlessApply' to fix code style运行 './gradlew :catalogs:catalog-jdbc-common:spotlessApply' 修复代码样式

Can I use idea one click formatting?

@mchades
Copy link
Contributor

mchades commented Oct 30, 2024

Can I use idea one click formatting?

no, need to run the command in the terminal.

@lsyulong
Copy link
Contributor Author

Can I use idea one click formatting?

no, need to run the command in the terminal.

image
How should I operate

@mchades
Copy link
Contributor

mchades commented Oct 30, 2024

Sorry, it looks like you are using a Windows OS, I cannot provide advice. This command needs to be executed on Linux.

@lsyulong
Copy link
Contributor Author

Sorry, it looks like you are using a Windows OS, I cannot provide advice. This command needs to be executed on Linux.

image
Can I manually indent it? I haven't made any changes elsewhere

@mchades
Copy link
Contributor

mchades commented Oct 30, 2024

FYI:
https://github.com/apache/gravitino/actions/runs/11570667372/job/32207125956?pr=5337

@lsyulong
Copy link
Contributor Author

Is there any problem with the latest submitted code? If there is, I will make the necessary modifications @mchades

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchades mchades mchades left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Some JDBC catalog properties should be defined as required
2 participants
@lsyulong @mchades