-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5306][Improvement] Some JDBC catalog properties should be defined as required #5337
base: main
Are you sure you want to change the base?
Conversation
JdbcConfig.JDBC_DRIVER.getKey(), | ||
JdbcConfig.JDBC_DRIVER.getDoc(), | ||
true /* required */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you plz add tests to cover the changes?
Run |
Can I use idea one click formatting? |
no, need to run the command in the terminal. |
Sorry, it looks like you are using a Windows OS, I cannot provide advice. This command needs to be executed on Linux. |
Is there any problem with the latest submitted code? If there is, I will make the necessary modifications @mchades |
What changes were proposed in this pull request?
[#5306][Improvement] Some JDBC catalog properties should be defined as required
Why are the changes needed?
Fix: #5306
Does this PR introduce any user-facing change?
change some JDBC catalog properties
How was this patch tested?
No