[#5315] doc(iceberg): add credential vending document for Iceberg REST Server #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
|
@jerryshao @yuqi1129 @jerqi please help to review when you have time, thanks |
jerryshao
reviewed
Oct 29, 2024
docs/iceberg-rest-service.md
Outdated
| @@ -361,7 +371,7 @@ For example, we can configure Spark catalog options to use Gravitino Iceberg RES | |||
| --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/ | |||
| ``` | |||
|
|
|||
| You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed because related properties is transferred from Iceberg REST server to Iceberg REST client automatically. | |||
| You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed if you enable credential vending in the server side by setting `credential-provider-type` and enable credential vending request in client side by setting `spark.sql.catalog.rest.header.X-Iceberg-Access-Delegation` = `vended-credentials`. | |||
There was a problem hiding this comment.
This sentence is too long, you should break it into several short sentences.
jerryshao
reviewed
Oct 29, 2024
docs/iceberg-rest-service.md
Outdated
| @@ -371,7 +371,7 @@ For example, we can configure Spark catalog options to use Gravitino Iceberg RES | |||
| --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/ | |||
| ``` | |||
|
|
|||
| You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed if you enable credential vending in the server side by setting `credential-provider-type` and enable credential vending request in client side by setting `spark.sql.catalog.rest.header.X-Iceberg-Access-Delegation` = `vended-credentials`. | |||
| You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark. If you want to enable credential vending, please setting `credential-provider-type` to proper value in server side, setting `spark.sql.catalog.rest.header.X-Iceberg-Access-Delegation` = `vended-credentials` in client side. | |||
There was a problem hiding this comment.
There are "two" whitespaces before "please", please remove one.
"please set xxx to a proper value in the server side, set xxx in the client side."
FANNG1
force-pushed
the
credential-doc
branch
from
5387322
to
298de0b
Compare
jerryshao
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add credential vending document for Iceberg REST Server
Why are the changes needed?
Fix: #5315
Does this PR introduce any user-facing change?
no
How was this patch tested?
just document