Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4170] improve(IT): clarify skip Docker test messages #4944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xunliu
Copy link
Member

@xunliu xunliu commented Sep 14, 2024

What changes were proposed in this pull request?

  1. Add a extension to the AbstractIT class
  2. Before runing ITs check Docker environment, and use log4j to print message in the IDEA console.

Why are the changes needed?

Before:
image

After:
image

Fix: #4170

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

CI Passed.

@jerryshao
Copy link
Contributor

@xunliu what is the purpose of adding this extension? My thinking is that if we run the ITs using gradle, then there'll be so many log output for each test. This is helpful for debugging one IT on idea, but seems not so useful when we run all the ITs using gradle. WDYT?

@yuqi1129
Copy link
Contributor

Yeah, this is very useful when developing Gravitino locally, especially for those who are not familiar with it. They may encounter unexpected issues while debugging integration tests.

@jerryshao
Copy link
Contributor

jerryshao commented Sep 18, 2024

I think we already output such information in the idea output, as I just confirmed with @yuqi1129 offline.

image

@yuqi1129
Copy link
Contributor

2. Before runing ITs check Docker environment, and use log4j to print message in the IDEA console.

image @xunliu , I believe you can add this line to show the root cause of why we can't run this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] clarify docker test failure messages
3 participants