Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Some JDBC catalog properties should be defined as required #5306

Open
mchades opened this issue Oct 28, 2024 · 6 comments · May be fixed by #5337
Open

[Improvement] Some JDBC catalog properties should be defined as required #5306

mchades opened this issue Oct 28, 2024 · 6 comments · May be fixed by #5337
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Oct 28, 2024

What would you like to be improved?

The following JDBC should be required not optional:

gravitino/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java

Lines 64 to 81 in 955d527

stringOptionalPropertyEntry(
JdbcConfig.JDBC_DRIVER.getKey(),
JdbcConfig.JDBC_DRIVER.getDoc(),
false /* immutable */,
null /* defaultValue */,
false /* hidden */),
stringOptionalPropertyEntry(
JdbcConfig.USERNAME.getKey(),
JdbcConfig.USERNAME.getDoc(),
false /* immutable */,
null /* defaultValue */,
false /* hidden */),
stringOptionalPropertyEntry(
JdbcConfig.PASSWORD.getKey(),
JdbcConfig.PASSWORD.getDoc(),
false /* immutable */,
null /* defaultValue */,
false /* hidden */),

How should we improve?

make them required
@mchades mchades added good first issue Good for newcomers improvement Improvements on everything labels Oct 28, 2024
@lsyulong
Copy link
Contributor

I want to try it, but I don't know how to modify it. Can you help me

@mchades
Copy link
Contributor Author

mchades commented Oct 28, 2024

For example, change the code of JDBC_DRIVER to:

stringPropertyEntry(
                JdbcConfig.JDBC_DRIVER.getKey(),
                JdbcConfig.JDBC_DRIVER.getDoc(),
                true /* required */,
                false /* immutable */,
                null /* defaultValue */,
                false /* hidden */,
                false /* reserved */)

@lsyulong
Copy link
Contributor

For example, change the code of JDBC_DRIVER to:

stringPropertyEntry(
                JdbcConfig.JDBC_DRIVER.getKey(),
                JdbcConfig.JDBC_DRIVER.getDoc(),
                true /* required */,
                false /* immutable */,
                null /* defaultValue */,
                false /* hidden */,
                false /* reserved */)

ok,thanks

lsyulong added a commit to lsyulong/gravitino that referenced this issue Oct 29, 2024
@lsyulong
[apache#5306][Improvement] Some JDBC catalog properties should be def…
36757d5 
…ined as required
@lsyulong
Copy link
Contributor 

            stringPropertyEntry(
            JdbcConfig.JDBC_DRIVER.getKey(),
            JdbcConfig.JDBC_DRIVER.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.USERNAME.getKey(),
            JdbcConfig.USERNAME.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.PASSWORD.getKey(),
            JdbcConfig.PASSWORD.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */)

@lsyulong
Copy link
Contributor 

            stringPropertyEntry(
            JdbcConfig.JDBC_DRIVER.getKey(),
            JdbcConfig.JDBC_DRIVER.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.USERNAME.getKey(),
            JdbcConfig.USERNAME.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.PASSWORD.getKey(),
            JdbcConfig.PASSWORD.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */)

Do you think there's a problem with this

@mchades
Copy link
Contributor Author

mchades commented Oct 29, 2024

Do you think there's a problem with this

looks good

@lsyulong lsyulong linked a pull request Oct 29, 2024 that will close this issue
Open
lsyulong added a commit to lsyulong/gravitino that referenced this issue Oct 30, 2024
@lsyulong
[apache#5306][Improvement] Some JDBC catalog properties should be def…
8d2d15e 
…ined as required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5306][Improvement] Some JDBC catalog properties should be defined as required lsyulong/gravitino
2 participants
@mchades @lsyulong