[Improvement] Some JDBC catalog properties should be defined as required

[mchades]

What would you like to be improved?

The following JDBC should be required not optional:

gravitino/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java

Lines 64 to 81 in 955d527

	stringOptionalPropertyEntry(
	JdbcConfig.JDBC_DRIVER.getKey(),
	JdbcConfig.JDBC_DRIVER.getDoc(),
	false /* immutable */,
	null /* defaultValue */,
	false /* hidden */),
	stringOptionalPropertyEntry(
	JdbcConfig.USERNAME.getKey(),
	JdbcConfig.USERNAME.getDoc(),
	false /* immutable */,
	null /* defaultValue */,
	false /* hidden */),
	stringOptionalPropertyEntry(
	JdbcConfig.PASSWORD.getKey(),
	JdbcConfig.PASSWORD.getDoc(),
	false /* immutable */,
	null /* defaultValue */,
	false /* hidden */),

How should we improve?

make them required

[lsyulong]

I want to try it, but I don't know how to modify it. Can you help me

[mchades]

For example, change the code of JDBC_DRIVER to:

stringPropertyEntry(
                JdbcConfig.JDBC_DRIVER.getKey(),
                JdbcConfig.JDBC_DRIVER.getDoc(),
                true /* required */,
                false /* immutable */,
                null /* defaultValue */,
                false /* hidden */,
                false /* reserved */)

[lsyulong]

For example, change the code of JDBC_DRIVER to:

stringPropertyEntry(
                JdbcConfig.JDBC_DRIVER.getKey(),
                JdbcConfig.JDBC_DRIVER.getDoc(),
                true /* required */,
                false /* immutable */,
                null /* defaultValue */,
                false /* hidden */,
                false /* reserved */)

ok,thanks

[lsyulong]

            stringPropertyEntry(
            JdbcConfig.JDBC_DRIVER.getKey(),
            JdbcConfig.JDBC_DRIVER.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.USERNAME.getKey(),
            JdbcConfig.USERNAME.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.PASSWORD.getKey(),
            JdbcConfig.PASSWORD.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */)

[lsyulong]

            stringPropertyEntry(
            JdbcConfig.JDBC_DRIVER.getKey(),
            JdbcConfig.JDBC_DRIVER.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.USERNAME.getKey(),
            JdbcConfig.USERNAME.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */),
            stringPropertyEntry(
            JdbcConfig.PASSWORD.getKey(),
            JdbcConfig.PASSWORD.getDoc(),
            true /* required */,
            false /* immutable */,
            null /* defaultValue */,
            false /* hidden */,
            false /* reserved */)

Do you think there's a problem with this

[mchades]

Do you think there's a problem with this

looks good