Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36542] Enable upToDateChecking to speed up the spotless #25525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruanwenjun
Copy link
Member

What is the purpose of the change

Speed up the spotless.
JIRA: https://issues.apache.org/jira/browse/FLINK-36542

Brief change log

  • Enable upToDateChecking in spotless-maven-plugin

Verifying this change

Use mvn spotless:apply or mvn spotless:check to verify.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 15, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@vahmed-hamdy
Copy link
Contributor

Nice quick optimisation, thanks!

Copy link
Contributor

@vahmed-hamdy vahmed-hamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ruanwenjun
Copy link
Member Author

Nice quick optimisation, thanks!

I am very happy to be able to make something that will help flink!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants