Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primary storage update form not showing existing values #9809

Merged

Conversation

winterhazel
Copy link
Collaborator

Description

Fixes the bug described in #9806. The primary storage update form is not showing the existing values of the following fields: tags, is tag a rule, capacity bytes, IOPS total and NFS mount options.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

I accessed a NFS primary storage's details page, enabled maintenance mode and edited its name, tags, tag as JS rule, capacity bytes, IOPS total and NFS mount options fields. Then, I opened the edit form again and verified that the updated values were shown.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (4459772) to head (fd973d3).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9809      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
- Complexity    11198    11201       +3     
============================================
  Files          5404     5404              
  Lines        473418   473417       -1     
  Branches      60717    61775    +1058     
============================================
- Hits          71425    71416       -9     
- Misses       394044   394053       +9     
+ Partials       7949     7948       -1     
Flag Coverage Δ
uitests 4.30% <ø> (+<0.01%) ⬆️
unittests 15.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kiranchavala
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build failed: ✖️
(SL-JID-462)

@kiranchavala
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build failed: ✖️
(SL-JID-463)

@kiranchavala
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11373

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Oct 17, 2024
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Able to edit the storage pool tags

Screenshot 2024-10-17 at 5 57 15 PM
Screenshot 2024-10-17 at 5 58 35 PM

@rohityadavcloud rohityadavcloud merged commit 175eed2 into apache:4.19 Oct 18, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants