Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix unit tests #9798

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes the UI unit test failures

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (017cf2c) to head (03c9b38).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9798      +/-   ##
============================================
- Coverage     15.80%   15.08%   -0.72%     
- Complexity    11199    11200       +1     
============================================
  Files          5038     5404     +366     
  Lines        443875   473417   +29542     
  Branches      52607    58747    +6140     
============================================
+ Hits          70139    71416    +1277     
- Misses       365934   394054   +28120     
- Partials       7802     7947     +145     
Flag Coverage Δ
uitests 4.30% <ø> (?)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Oct 16, 2024
@vishesh92 vishesh92 mentioned this pull request Oct 16, 2024
9 tasks
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. And the UI build is successful.

@vishesh92 vishesh92 merged commit 9661060 into apache:4.19 Oct 16, 2024
24 of 26 checks passed
@rohityadavcloud
Copy link
Member

cc @JoaoJandre fwd-merging this build/UI failure on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants