Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable API Key Access for users, accounts and domains #9741

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Fix events generated to set Username, Account and Domain of the calle…

a9805b5
Select commit
Loading
Failed to load commit list.
Draft

Disable API Key Access for users, accounts and domains #9741

Fix events generated to set Username, Account and Domain of the calle…
a9805b5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

15.82% (+0.03%) compared to 046870e

View this Pull Request on Codecov

15.82% (+0.03%) compared to 046870e

Details

Codecov Report

Attention: Patch coverage is 25.73840% with 176 lines in your changes missing coverage. Please review.

Project coverage is 15.82%. Comparing base (046870e) to head (a9805b5).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...com/cloud/network/vpn/Site2SiteVpnManagerImpl.java 0.00% 48 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServer.java 22.72% 17 Missing ⚠️
...c/main/java/com/cloud/user/dao/AccountDaoImpl.java 0.00% 14 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java 0.00% 13 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 47.82% 7 Missing and 5 partials ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java 75.00% 6 Missing and 4 partials ⚠️
...n/java/org/apache/cloudstack/api/ApiConstants.java 47.05% 9 Missing ⚠️
...ne/schema/src/main/java/com/cloud/user/UserVO.java 0.00% 6 Missing ⚠️
...ck/api/command/admin/account/UpdateAccountCmd.java 0.00% 5 Missing ⚠️
...loudstack/api/command/admin/user/ListUsersCmd.java 0.00% 5 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9741      +/-   ##
============================================
+ Coverage     15.78%   15.82%   +0.03%     
- Complexity    12552    12587      +35     
============================================
  Files          5625     5628       +3     
  Lines        491972   492483     +511     
  Branches      63764    60018    -3746     
============================================
+ Hits          77664    77912     +248     
- Misses       405849   406059     +210     
- Partials       8459     8512      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov