Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabricksHook: fix status property to work with ClientResponse used in async mode #43333

Merged

Conversation

lucafurrer
Copy link
Contributor

@lucafurrer lucafurrer commented Oct 23, 2024

closes: #43269

The object returned in by request_func in the _a_do_api_call is not a request.Response as in the synchronous call but a ClientResponse which does not have the property status_code but status


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 23, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Oct 24, 2024

Can you please add/modify a unit test for it to avoid regression?

@lucafurrer
Copy link
Contributor Author

Can you please add/modify a unit test for it to avoid regression?

Sure, I will try

@rawwar
Copy link
Collaborator

rawwar commented Oct 24, 2024

Can you please add/modify a unit test for it to avoid regression?

Sure, I will try

@lucafurrer , if you would like some help, I can write the test case for this. Thanks for fixing it.

@lucafurrer
Copy link
Contributor Author

Can you please add/modify a unit test for it to avoid regression?

Sure, I will try

@lucafurrer , if you would like some help, I can write the test case for this. Thanks for fixing it.

@rawwar Hi, I will not have time before tonight to look into it. If you want go for it.

@rawwar
Copy link
Collaborator

rawwar commented Oct 24, 2024

@rawwar Hi, I will not have time before tonight to look into it. If you want go for it.

Won't be able to do it right now. But, i can finish this in this week

@lucafurrer
Copy link
Contributor Author

@potiuk, @rawwar I added an unit test. Comments are welcome.
Challenge is that the problem only appears when logging is enabled and the object which had invalid property is mocked as it is the response from the API.

@potiuk potiuk merged commit 7e56dac into apache:main Oct 25, 2024
56 checks passed
Copy link

boring-cyborg bot commented Oct 25, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants