Fix Tests since MWA is no longer autoselected #1021
Conversation
| it('should not clear the stored wallet name', () => { | ||
| expect(localStorage.removeItem).not.toHaveBeenCalled(); | ||
| it('should clear the stored wallet name', () => { | ||
| expect(localStorage.removeItem).toHaveBeenCalled(); |
There was a problem hiding this comment.
Hmm. I think the original intent of the test is correct -- the wallet disconnecting should NOT deselect the wallet or remove it from LocalStorage, because then autoconnect will be broken on reload.
There was a problem hiding this comment.
is this true? AFAICT when using wallet adapter, autoconnect is not supposed to reload the last used wallet if disconnect was called
| renderTest({}); | ||
| expect(ref.current?.getWalletContextState().wallet?.adapter.name).toBe(SolanaMobileWalletAdapterWalletName); | ||
| expect(ref.current?.getWalletContextState().wallet?.adapter.name).toBe(undefined); |
There was a problem hiding this comment.
I think instead tests need to be changed/added such that
- If MWA (custom or default) is the only adapter, it should be selected by default.
- If it's not the only adapter, no adapter should be selected by default.
I think this satisfies the intent of the new code this is targeting.
| beforeEach(async () => { | ||
| errorThrown = new WalletError('o no'); | ||
| onError = jest.fn(); | ||
| renderTest({ onError }); | ||
| await act(async () => { | ||
| ref.current?.getWalletContextState().select(SolanaMobileWalletAdapterWalletName); | ||
| await Promise.resolve(); // Flush all promises in effects after calling `select()`. | ||
| }); |
There was a problem hiding this comment.
This change doesn't make sense to me. MWA shouldn't be deselected after each test, given the comment following this one)
There was a problem hiding this comment.
hey sorry, not sure I totally follow – I don't think there's any selecting involved, the test is just to make sure that when the adapter emits an error, it expects onError to be called. or was the point of the test something different?
No description provided.