feat: add grid line plugin #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Mar 5, 2024
Aarebecca
commented
- 新增网格线插件，用于验证插件机制能力
- Add the grid-line plugin to verify the plugin mechanism capability
|
由于 grid 是使用 dom 绘制的，所以没有添加截图 |
hustcc
reviewed
Mar 6, 2024
| @@ -357,11 +358,11 @@ export class Graph extends EventEmitter { | |||
| * <en/> This process will execute data update, element rendering, and layout execution | |||
| */ | |||
| public async render(): Promise<void> { | |||
| emit(this, new RenderEvent(GraphEvent.BEFORE_RENDER)); | |||
| emit(this, new GraphLifeCycleEvent(GraphEvent.BEFORE_RENDER)); | |||
There was a problem hiding this comment.
这里用 this.emit 就可以了？完全没有必要再封装一层，我看 emit 方法也没有做额外的事情。
There was a problem hiding this comment.
这里用 this.emit 就可以了？完全没有必要再封装一层，我看 emit 方法也没有做额外的事情。
主要还是简写，如果直接 emit 的话，所有 emit 的地方就需要拆成两行写
const event = new GraphLifeCycleEvent(GraphEvent.BEFORE_RENDER);
this.emit(event.type, event);
hustcc
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.