feat(combo): add rect combo element #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonneyx
force-pushed
the
feat/rect-combo
branch
from
a173ef2
to
0de7ec9
Compare
Aarebecca
reviewed
Mar 5, 2024
Aarebecca
reviewed
Mar 5, 2024
packages/g6/src/types/element.ts
Outdated
| * <en/> The origin of combo when collapsed | ||
| */ | ||
| collapsedOrigin?: string | [number, number]; | ||
| collapsedOrigin?: |
There was a problem hiding this comment.
我看好几个地方都用到了类似的 position（比如 LoopEdgePosition, RelativePosition），可否统一组织一下呢
There was a problem hiding this comment.
统一到 Placement
export type CardinalPlacement = 'left' | 'right' | 'top' | 'bottom';
export type CornerPlacement =
| 'left-top'
| 'left-bottom'
| 'right-top'
| 'right-bottom'
| 'top-left'
| 'top-right'
| 'bottom-left'
| 'bottom-right';
export type Placement = CardinalPlacement | CornerPlacement | 'center';
Aarebecca
reviewed
Mar 5, 2024
Aarebecca
reviewed
Mar 5, 2024
Aarebecca
reviewed
Mar 6, 2024
| | 'right' | ||
| | 'right-top' | ||
| | 'right-bottom'; | ||
| export type LoopEdgePosition = CardinalPlacement | CornerPlacement; |
There was a problem hiding this comment.
这里 Position 都改为 Placement 吧～
yvonneyx
force-pushed
the
feat/rect-combo
branch
2 times, most recently
from
a56c90f
to
8e05997
Compare
yvonneyx
force-pushed
the
feat/rect-combo
branch
from
8e05997
to
56e548d
Compare
Aarebecca
approved these changes
Mar 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collapsedOrigin来控制收起时的原点位置，取值为'left' | 'right' | 'top' | 'bottom' | 'top-left' | 'top-right' | 'bottom-left' | 'bottom-right' | [number, number]。例如，如果设置成'top-left'，则朝元素的左上角收起collapsedMarkerType