Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicated dragend case #5161

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: remove duplicated dragend case #5161

merged 1 commit into from
Nov 29, 2023

Conversation

kingyue737
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

case "dragend" already exists above:

G6/packages/pc/src/graph/controller/event.ts

Line 91 in 304db35

case 'dragend':

this extra line will result to esbuild warning:

(esbuild plugin) [esbuild] (.nuxt/dist/server/_nuxt/electronic-372bd534.js:31248:13) This case clause will never be evaluated because it duplicates an earlier case clause

@kingyue737 kingyue737 mentioned this pull request Nov 28, 2023
Closed
@Aarebecca Aarebecca merged commit ae0ed42 into antvis:master Nov 29, 2023
4 checks passed
@kingyue737 kingyue737 deleted the patch-1 branch November 29, 2023 03:32
k644606347 pushed a commit to k644606347/G6 that referenced this pull request Mar 23, 2024
@kingyue737
fix: remove duplicated dragend case (antvis#5161)
e027013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Aarebecca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingyue737 @Aarebecca