fix: update isStyleEqual

antvis · Oct 15, 2024 · 5186208 · 5186208
1 parent f9318e9
commit 5186208
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/g6/__tests__/demos/transform-map-node-size.ts b/packages/g6/__tests__/demos/transform-map-node-size.ts
@@ -32,7 +32,7 @@ export const transformMapNodeSize: TestCase = async (context) => {
 
  await graph.render();
 
- const config = { 'centrality.type': 'eigenvector', mapLabelSize: false };
+ const config = { 'centrality.type': 'degree', mapLabelSize: false };
 
  transformMapNodeSize.form = (panel) => [
  panel

diff --git a/packages/g6/src/transforms/map-node-size.ts b/packages/g6/src/transforms/map-node-size.ts
@@ -1,4 +1,4 @@
-import { deepMix, isEqual, pick } from '@antv/util';
+import { deepMix, pick } from '@antv/util';
 import type { RuntimeContext } from '../runtime/types';
 import type { GraphData, NodeData } from '../spec';
 import type { NodeStyle } from '../spec/element/node';
@@ -12,7 +12,7 @@ import { parseSize } from '../utils/size';
 import type { BaseTransformOptions } from './base-transform';
 import { BaseTransform } from './base-transform';
 import type { DrawData } from './types';
-import { reassignTo } from './utils';
+import { isStyleEqual, reassignTo } from './utils';
 
 export interface MapNodeSizeOptions extends BaseTransformOptions {
  /**
@@ -127,10 +127,8 @@ export class MapNodeSize extends BaseTransform<MapNodeSizeOptions> {
  const style: NodeStyle = { size };
  this.assignLabelStyle(style, size, datum, element);
 
- const isStyleEqual = element && Object.keys(style).every((key) => isEqual(style[key], element.attributes[key]));
-
- if (!element || !isStyleEqual) {
- reassignTo(input, element ? 'update' : 'add', 'node', deepMix(datum, { style }));
+ if (!element || !isStyleEqual(style, element.attributes)) {
+ reassignTo(input, element ? 'update' : 'add', 'node', deepMix(datum, { style }), true);
  }
  });
  return input;