wip: perf optimize proposal #1789
Open
+1,333
−3,796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Aarebecca
force-pushed
the
perf/optimize-proposal
branch
from
b4c820b
to
af9d607
Compare
Aarebecca
force-pushed
the
perf/optimize-proposal
branch
2 times, most recently
from
99a1b4a
to
01ba274
Compare
Aarebecca
force-pushed
the
perf/optimize-proposal
branch
from
01ba274
to
1dd60b5
Compare
Aarebecca
force-pushed
the
perf/optimize-proposal
branch
from
259ce4e
to
4cc14d0
Compare
Comment on lines
+143
to
+144
| !isNaN(rBushNode.aabb.maxX) && | ||
| !isNaN(rBushNode.aabb.maxX) && |
Check warning
Code scanning / CodeQL
Identical operands Warning
Aarebecca
force-pushed
the
perf/optimize-proposal
branch
from
448fad0
to
a32363c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.