Update the versions of a few tools #6767
Conversation
luolanzone
commented
Oct 24, 2024
luolanzone
commented
- Update trivy version to v0.56.2
- Update jnorwood/helm-docs image tag to v1.14.2
- Update controller-gen version in codegen Dockerfile to v0.16.3
| @@ -48,7 +48,7 @@ RUN go install k8s.io/code-generator/cmd/client-gen@kubernetes-$K8S_VERSION && \ | |||
| go install google.golang.org/protobuf/cmd/[email protected] && \ | |||
| go install google.golang.org/grpc/cmd/[email protected] && \ | |||
| go install golang.org/x/tools/cmd/goimports@latest && \ | |||
| go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0 | |||
| go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.16.3 | |||
There was a problem hiding this comment.
@antoninbas Do we need to update the codegen image because of this change?
It was supposed to be changed in this commit a1e0a75 accroding to the doc:
| kubernetes-1.31.1 | Upgraded K8s libraries to v1.31.1, controller-gen to v0.16.3, ubuntu to 24.04 |
but it seems we missed this last time.
There was a problem hiding this comment.
My bad. I must have lost that change when I reorganized commits in the PR before submitting it for review.
Yes, we should update the codegen image. I have pushed antrea/codegen:kubernetes-1.31.1-build.1:
C02F16ASMD6R:codegen abas$ docker run -ti antrea/codegen:kubernetes-1.31.1-build.1 bash
root@cbc09d4c9e99:/go# controller-gen --version
Version: v0.16.3
Please add a line in the README:
| kubernetes-1.31.1-build.1 | Upgraded controller-gen to v0.16.3
And edit the one for kubernetes-1.31.1 to remove the invalid controller-gen mention
I checked and it seems updating to controller-gen v0.16.3 didn't have an impact to generated fields. I am not sure which files are generated this way, is it just multicluster/apis/multicluster/v1alpha1/zz_generated.deepcopy.go and multicluster/apis/multicluster/v1alpha2/zz_generated.deepcopy.go?
There was a problem hiding this comment.
Updated.
Yes, multicluster codes generation will use this tool.
luolanzone
force-pushed
the
update-tool-versions
branch
from
ad18a49
to
14633ae
Compare
1. Update trivy version to v0.56.2 2. Update jnorwood/helm-docs image tag to v1.14.2 3. Update controller-gen version in codegen Dockerfile to v0.16.3 Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
update-tool-versions
branch
from
14633ae
to
b9e4dc9
Compare
