Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft PR for #6722 -- cache TTLs for individual IP addresses in DNS responses. #6732

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Draft PR for #6722 -- cache TTLs for individual IP addresses in DNS responses. #6732

wants to merge 7 commits into from

Commits on Oct 14, 2024

  1. initial commit towards resolving issue antrea-io#6722 

    Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    35efe2c View commit details
    Browse the repository at this point in the history

  2. added test case 

    Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5fbf0f1 View commit details
    Browse the repository at this point in the history

  3. modified parseDnsResponse and made changes to TestOnDNSResponse in fq… 

    …dn_test.go

Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ced107a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. updated onDNSResponse function as per reviews. 

     -- updated min and max logic for individual IPs and for adding items to queue
updated tests.

Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    654d819 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. moved minTime and maxTime outside onDnsResponse function as 

    earlierOf and laterOf functions.
reeduced verbosity by converting repeated code as anonymous function

Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    da89d20 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. corrected the value of minTimeToReQuery to 24 hours as max value inst… 

    …ead of previous very large value.

changed the name of closure to addIPToCache
refactored addIPToCache to skip passing of minTimeToReQuery as parameter as its accessible automatically being inside scope of outer function.
updated tests to cover inidividual scenarios .

Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    002a6ee View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. refactored onDNSResponse function. 

    Signed-off-by: Hemant <[email protected]>
    @hkiiita
    hkiiita committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3a15d7c View commit details
    Browse the repository at this point in the history