-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in EgressController and unit tests #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipAllocatorMap was read without holding the mutex in syncEgressIP. This patch fixes it and stabilizes the unit tests by waiting for cache sync before starting creating objects. This is because resource creation events will be missing if the resources are created in-between list and watch call of an fake informer. Signed-off-by: Quan Tian <[email protected]>
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
+ Coverage 62.05% 65.96% +3.91%
==========================================
Files 277 280 +3
Lines 21588 22417 +829
==========================================
+ Hits 13396 14788 +1392
+ Misses 6792 6157 -635
- Partials 1400 1472 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Jun 24, 2021
/test-all |
/test-e2e |
abhiraut
approved these changes
Jun 24, 2021
/test-e2e |
/skip-e2e The only failure is not related to this PR and has been tracked in #2283. Merging this PR to stabilize unit tests in main branch.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipAllocatorMap was read without holding the mutex in syncEgressIP. This
patch fixes it and stabilizes the unit tests by waiting for cache sync
before starting creating objects. This is because resource creation
events will be missing if the resources are created in-between list and
watch call of an fake informer.
Signed-off-by: Quan Tian [email protected]