Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant countries prefix on config keys #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lupinitylabs
Copy link

Using https://github.com/antonioribeiro/countries-laravel, there is no way to enable or disable caching by overwriting the countries.php config. I found that this is due to redundant countries. prefixes in the Cache Service and Nette classes which lead to effectively reading from countries.countries.cache.enabled, thus ignoring any settings for cache.enabled.

This is reproducible by publishing the config and changing any of the cache settings, for example the temp directory. All of the settings will be ignored, because the request to countries.countries.cache.enabled will return null, which is cast to false when returned from the Cache's enabled() method.

This PR will remove the redundant countries prefixes and will presumably also fix antonioribeiro/countries-laravel#17.

…nd Nette classes with will effectively read from `countries.countries.cache.enabled`.
@lupinitylabs
Copy link
Author

The original code does not seem to be formatted to match the StyleCI settings.
Do you want me to change and commit the doc block formatting accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No cache is being created.
1 participant