Make release workflow based on GH releases (#118)

.github/workflows/ci.yaml

@@ -67,53 +67,3 @@ jobs:
           minimum_coverage: 80
           show_missing: true
           show_branch: true
-
-  release:
-    name: Create release
-    runs-on: ubuntu-latest
-    needs: [lint, test]
-    if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/rr/v')
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: ${{ matrix.python-version }}
-      - name: pip cache
-        uses: actions/cache@v1
-        with:
-          path: ~/.cache/pip
-          key: ${{ runner.os }}-pip-${{ hashFiles('setup.cfg') }}
-          restore-keys: ${{ runner.os }}-pip
-      - name: Install build dependencies
-        run: |
-          python3 -m pip install --upgrade wheel setuptools .
-      - name: Validate version
-        id: version
-        run: |
-          tagged_version=${GITHUB_REF#refs/tags/rr/v}
-          code_version=$(python3 -c 'import phantom; print(phantom.__version__)')
-          if [[ "$tagged_version" != "$code_version" ]]; then
-            echo "Aborting due to version mismatch 💥"
-            echo "Tagged version: $tagged_version"
-            echo "Code version: $code_version"
-            exit 1
-          fi
-          echo "::set-output name=version::$tagged_version"
-      - name: Build
-        run: make build
-      - name: Publish
-        uses: pypa/gh-action-pypi-publish@release/v1
-        with:
-          user: __token__
-          password: ${{ secrets.PYPI_API_TOKEN }}
-      - name: Tag release
-        uses: actions/create-release@v1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          tag_name: ${{ steps.version.outputs.version }}
-          release_name: ${{ steps.version.outputs.version }}
-          draft: false
-          prerelease: false
-          body: ""

.github/workflows/release.yaml

@@ -0,0 +1,27 @@
+name: Release
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build-and-publish:
+    name: Build and publish
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-python@v2
+    - name: pip cache
+      uses: actions/cache@v2
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('setup.cfg') }}
+        restore-keys: ${{ runner.os }}-pip
+    - name: Install dependencies
+      run: python3 -m pip install --upgrade build
+    - name: Build
+      run: python3 -m build --sdist --wheel .
+    - name: Publish
+      uses: pypa/gh-action-pypi-publish@release/v1
+      with:
+        password: ${{ secrets.PYPI_API_TOKEN }}

.pre-commit-config.yaml

@@ -56,6 +56,10 @@ repos:
           - iso3166
           - phonenumbers
           - pydantic
+  - repo: https://github.com/mgedmin/check-manifest
+    rev: "0.46"
+    hooks:
+      - id: check-manifest
 
 exclude: |
   (?x)(

MANIFEST.in

@@ -0,0 +1,10 @@
+exclude Makefile
+recursive-exclude docs *
+recursive-exclude examples *
+recursive-exclude .github *
+recursive-exclude tests *
+recursive-include phantom py.typed
+exclude *.yaml
+exclude *.yml
+include README.md
+include LICENSE

Makefile

@@ -21,6 +21,7 @@ coverage-report:
 	@coverage report
 	@coverage xml
 
+# TODO: Move to pre-commit
 .PHONY: format-readme
 format-readme:
 	docker run \
@@ -36,16 +37,3 @@ format-readme:
 .PHONY: clean
 clean:
 	rm -rf *.egg-info **{/**,}/__pycache__ build dist .coverage
-
-.PHONY: build
-build: clean
-	python3 -m pip install --upgrade wheel setuptools
-	python3 setup.py sdist bdist_wheel
-
-.PHONY: create-release
-create-release:
-	(\
-	  tag="rr/v$$(python3 -c 'import phantom; print(phantom.__version__)')";\
-	  git tag "$$tag";\
-	  git push origin "$$tag";\
-	)