[java20] Fix for identifiers #4209 #4229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects occurrences of
Identifier
, which was done incorrectly. As stated in the Spec, Identifier is a "IdentifierChars but not a ReservedKeyword or BooleanLiteral or NullLiteral". But it should include generallyContexualKeyword
. Antlr does not have a "not"-operator for parser grammars, so the rule must be refactored as what can be included. AKeyword
is a "ReservedKeyword | ContextualKeyword." This PR definescontextualKeyword
and subsets, which are used in a couple of places.