Fix for #3630 #3631
Merged
Fix for #3630 #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file io and removed unused imports
kaby76
reviewed
Jul 26, 2023
| from glob import glob | ||
| from pathlib import Path | ||
|
|
||
| def main(argv): | ||
| for file in glob("./parser/*.g4"): |
There was a problem hiding this comment.
The "parser/" directory is required because he Antlr tool generates code with a "package parser" declaration. And, there's no way to stop the Antlr tool from doing that. Either include "parser/" in the string passed to glob, or maybe just recurse/glob "*.g4"?
There was a problem hiding this comment.
BTW, I'm hoping all this "transformGrammar.py" hack can go away with antlr/antlr4#4345. But, who knows if it will be added.
|
I added the "parser/"directory in the string passed to glob. If it goes away. Then that is the way it is. I just wanted to contribute something. |
|
@pasto9 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the scripts more pythonic, used contextmanagers for the file io and used regEx to for finding and replacing the strings.
While working on it I tried to stick to pylints conventions for coding styles.
This is my first pr on a public repo. So please let me know if I did anything wrong.