Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromQL: Added missing trigonometric functions #3612

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

Sageder
Copy link
Contributor

@Sageder Sageder commented Jul 14, 2023

This pull request adds the missing trigonometric functions to the promql grammar: acos, acosh, asin, asinh, etc. You can see a list of functions in promql here.

@KvanTTT KvanTTT added the promql label Jul 14, 2023
Copy link
Member

@KvanTTT KvanTTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add/extend an example that covers suggested changes.

@Sageder
Copy link
Contributor Author

Sageder commented Jul 14, 2023

I added an example to function.txt:

sin(rate(http_requests_total[5m]))

@KvanTTT KvanTTT merged commit c3b0e61 into antlr:master Jul 14, 2023
2 of 39 checks passed
@KvanTTT
Copy link
Member

KvanTTT commented Jul 14, 2023

Welcome to ANTLR grammars repository!

@kaby76
Copy link
Contributor

kaby76 commented Jul 14, 2023

The build is broken. https://github.com/antlr/grammars-v4/actions/runs/5554306328/jobs/10143937514#step:22:113

Please correct.

@KvanTTT
Copy link
Member

KvanTTT commented Jul 15, 2023

Sorry, I haven't noticed that. I'll fix it ASAP.

@KvanTTT KvanTTT mentioned this pull request Jul 15, 2023
rvrooman-codelogic pushed a commit to CodeLogicIncEngineering/grammars-v4-public-fork that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants