Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysinfo unit test #832

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Add sysinfo unit test #832

merged 11 commits into from
Sep 6, 2023

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

@thom-at-redhat thom-at-redhat marked this pull request as ready for review August 31, 2023 10:34
@AaronH88
Copy link
Contributor

Here is my concern with testify/assert : stretchr/testify#811

This issue specifies a possible work around that upon viewing seems to add a lot to any benchmark using it.

I also encouraged the use of table driven unit tests in golang, https://dev.to/boncheff/table-driven-unit-tests-in-go-407b
You can see that in the code that Chris, Matthew and myself have recently merged.

I have no problem revisiting these approaches, and so long as any tests we write are easy to read, debug and benchmark I am happy with the team decision (now that their is a team)

pkg/utils/sysinfo_test.go Outdated Show resolved Hide resolved
pkg/utils/sysinfo_test.go Outdated Show resolved Hide resolved
@thom-at-redhat thom-at-redhat changed the title AAP-14352: Add sysinfo unit test Add sysinfo unit test Sep 1, 2023
@thom-at-redhat
Copy link
Contributor Author

Here is my concern with testify/assert : stretchr/testify#811

This issue specifies a possible work around that upon viewing seems to add a lot to any benchmark using it.

I also encouraged the use of table driven unit tests in golang, https://dev.to/boncheff/table-driven-unit-tests-in-go-407b You can see that in the code that Chris, Matthew and myself have recently merged.

I have no problem revisiting these approaches, and so long as any tests we write are easy to read, debug and benchmark I am happy with the team decision (now that their is a team)

As we discussed, removing the use of testify here

pkg/utils/sysinfo_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit e25f8ef into ansible:devel Sep 6, 2023
11 checks passed
AaronH88 pushed a commit to AaronH88/receptor that referenced this pull request Oct 5, 2023
@thom-at-redhat thom-at-redhat deleted the AAP-14352 branch October 18, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants