-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysinfo unit test #832
Conversation
Here is my concern with testify/assert : stretchr/testify#811 This issue specifies a possible work around that upon viewing seems to add a lot to any benchmark using it. I also encouraged the use of table driven unit tests in golang, https://dev.to/boncheff/table-driven-unit-tests-in-go-407b I have no problem revisiting these approaches, and so long as any tests we write are easy to read, debug and benchmark I am happy with the team decision (now that their is a team) |
As we discussed, removing the use of testify here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.