Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display messages on all close errors in workunitbase #1192

Merged

Conversation

thom-at-redhat
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Oct 24, 2024

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 44.37%. Comparing base (5312a25) to head (230ccd9).
Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/workunitbase.go 11.76% 13 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##            devel    #1192      +/-   ##
==========================================
+ Coverage   43.98%   44.37%   +0.38%     
==========================================
  Files          33       36       +3     
  Lines        8090     8677     +587     
==========================================
+ Hits         3558     3850     +292     
- Misses       4261     4556     +295     
  Partials      271      271              
Files with missing lines Coverage Δ
pkg/workceptor/workunitbase.go 72.70% <11.76%> (-2.15%) ⬇️

... and 6 files with indirect coverage changes

Components Coverage Δ
Go 44.01% <11.76%> (+0.03%) ⬆️
Receptorctl 49.31% <ø> (∅)

@thom-at-redhat thom-at-redhat merged commit 234c21b into ansible:devel Oct 24, 2024
25 of 26 checks passed
@thom-at-redhat thom-at-redhat deleted the add_fsnotify_close_error_checking branch October 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants