Fix large SFTP reads

[Jakuje]

SUMMARY

Fixes and reproducers for large SFTP reads that truncate file with the second chunk.

Fixes: #341

ISSUE TYPE

• Bugfix Pull Request

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/ansible-pylibssh-638
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[kucharskim]

This will append content to the file which already exists. I've tested this diff with ansible-libssh v1.2.2 and only a60a6cb applied. I see multiple executions on the same destination file growing above original size:

remote-machine# ls -l /tmp/foo?
-rw-r--r--  1 root  wheel  1048576 Nov 15 12:31 /tmp/foo1
-rwx------  1 root  wheel  3145728 Nov 15 12:37 /tmp/foo3

local-machine$ ls -l /tmp/foo?
-rw-r--r--  1 mkucharski  wheel  3145728 Nov 15 12:35 /tmp/foo2

Above we see size 3x after 3 executions of:

t1 = sftp_session.get(remote_file, local_file)
t2 = sftp_session.put(local_file, new_remote_file)

I think this needs more work. Also mode doesn't match after put(), but that is another issue.

[Jakuje]

Thank you for throughful testing! Indeed, you are right. I thought this small change will make it working, but it looks like its more complicated. Updated the PR.

For the modes, I think this would be a different issue or rfe. Right now, the code opens the file with normal python open, which will probably set modes based on your umask, which will result in sane permissions. We could update the permissions based on what is on the server (if the server uses unix/linux ACL), but given that they will likely have different usernames and groups, it might result in unwanted permissions.

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud