Help text cleanup #638
Open
Help text cleanup #638
+482
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ class AzureADConfiguration(BaseAuthenticatorConfiguration): | |||
|
|
|||
| CALLBACK_URL = URLField( | |||
| help_text=_( | |||
| 'Provide this URL as the callback URL for your application as part of your registration process. Refer to the documentation for more detail. ' | |||
| 'Provide this URL as the callback URL for your application as part of your registration process. Refer to the documentation for more detail.' | |||
There was a problem hiding this comment.
Uniform Resource Locator (URL)
| @@ -32,7 +32,7 @@ class AzureADConfiguration(BaseAuthenticatorConfiguration): | |||
| ) | |||
|
|
|||
| SECRET = CharField( | |||
| help_text=_("'The OIDC secret (Client Secret) from your IDP."), | |||
| help_text=_("The OIDC secret (Client Secret) from your IDP."), | |||
There was a problem hiding this comment.
OpenID Connect (OIDC)
IDentity Provider (IDP)
| @@ -39,7 +39,7 @@ class OpenIdConnectConfiguration(BaseAuthenticatorConfiguration): | |||
| ################################# | |||
|
|
|||
| OIDC_ENDPOINT = URLField( | |||
| help_text=_("The URL for your OIDC provider including the path up to /.well-known/openid-configuration"), | |||
| help_text=_("The URL for your OIDC provider including the path up to /.well-known/openid-configuration."), | |||
There was a problem hiding this comment.
Uniform Resource Locator (URL)
OpenID Connect (OIDC)
| @@ -122,7 +122,7 @@ class OpenIdConnectConfiguration(BaseAuthenticatorConfiguration): | |||
| ) | |||
|
|
|||
| JWT_DECODE_OPTIONS = DictField( | |||
| help_text=_("OIDC JWT decoding options for token validation and processing"), | |||
| help_text=_("OIDC JWT decoding options for token validation and processing."), | |||
There was a problem hiding this comment.
OpenID Connection (OIDC)
JavScript Object Notation (JSON)
JSON Web Token (JWT)
| @@ -165,7 +165,7 @@ class OpenIdConnectConfiguration(BaseAuthenticatorConfiguration): | |||
| ) | |||
|
|
|||
| RESPONSE_TYPE = CharField( | |||
| help_text=_("The reponse type the OIDC endpoint should return. Common values are 'code', 'id_token' and 'token'."), | |||
| help_text=_("The response type the OIDC endpoint should return. Common values are 'code', 'id_token' and 'token'."), | |||
Comment on lines
19
to
21
| name='Authenticator', | ||
| fields=[ | ||
| ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), |
There was a problem hiding this comment.
We don't want to change existing migration files. That could theoretically cause issues and will make it so that you likely can't create new migrations (because it won't detect changes).
Comment on lines
91
to
95
| enabled = models.BooleanField( | ||
| null=False, | ||
| default=True, | ||
| help_text=_("Enables or disables this authentication map"), | ||
| ) |
There was a problem hiding this comment.
Is this en erroneous commit? Looks like it affects a couple files.
dmzoneill
force-pushed
the
help_text_cleanup
branch
from
d24716f
to
5135181
Compare
dmzoneill
force-pushed
the
help_text_cleanup
branch
from
5135181
to
485045e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.