-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Allow registering models via a setting #533
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that, and the change looks pretty clear, doc is there, 👍
df9e2ac
to
e0d8c53
Compare
Fix test failure due to app readiness
e0d8c53
to
f13e0c6
Compare
Quality Gate passedIssues Measures |
This may no longer be necessary. Waiting to see if its needed or not. |
It's not necessarily, but I might still like to do this, and take the entire project in this direction. But we should either agree we like this, and double-down further on it, or quit. How do we double-down? Because right now Why the heck would we do this? Because that would allow using That raises even more questions, because models will be modified and removed over time, as the state of the app changes... so does that mean you would create Big picture, then, DAB RBAC may do well to have a formalized way to record the historical state of registrations. |
This is a need come up looking at @jctanner 's integration work at ansible/galaxy_ng#2202
See the management command in particular and stuff like:
This seems to get us a list of "app_label.model_name" references of models. The current advice is to call
permission_registry.register
passing the model classes for all of those. Without getting into the technical constraints, there seems to be a pretty clear preference to just list these in a setting, which DAB RBAC can obvious handle without import-order-changing stuff.