[HOLD] Enable/Disable authentication maps #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmzoneill
force-pushed
the
aap-25778
branch
4 times, most recently
from
ea5addf
to
c64f9a5
Compare
relrod
reviewed
Jul 27, 2024
relrod
reviewed
Jul 27, 2024
|
relrod
reviewed
Jul 28, 2024
| enabled = models.BooleanField( | ||
| null=False, | ||
| default=True, | ||
| help_text=_("Enables or disables this authentication map"), |
There was a problem hiding this comment.
Suggested change
| help_text=_("Enables or disables this authentication map"), | |
| help_text=_("Enables or disables this authenticator map"), |
There was a problem hiding this comment.
Can we have a test for what happens when it's disabled? Just something that checks that it doesn't get applied.
john-westcott-iv
changed the title
john-westcott-iv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.