-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix issue where RADIUS auth logged to root logger (#637)
I was looking for this, because I made the same kind of mistake in another library. TBH, I think SonarCloud should create a rule to find these cases. `logging.info` goes to the _root_ logger. That is almost never what you want. Any configuration of the `ansible_base` logger will be ignored. I don't think we even customize the root logger in most cases, so the messages would likely be lost. The python standard library is deceptively permissive of this. Even though these cases are almost certainly a typo/goof, python accepts it as the programmer's intention.
- Loading branch information
1 parent
7933f91
commit 13ff878
Showing
1 changed file
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters