Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record the receptor unit ID on the job record for debugging purposes #9892

Merged

Conversation

ryanpetrello
Copy link
Contributor

see: #8641

image

@AlanCoding
Copy link
Member

This won't be in the actual job environment, will it?

@AlanCoding
Copy link
Member

I think I've confirmed that (via ansible/test-playbooks#153)

My thought was that a new UnifiedJob field would be a less confusing way to present that. Aside from system jobs, workflow jobs, and approval jobs, I think that all job types should have this non-blank.

@ryanpetrello
Copy link
Contributor Author

ryanpetrello commented Apr 12, 2021

@AlanCoding it won't, no. This JSON blob was just a convenient place to store the data without having to resort to a new column on a table that tends to be very large (schema changes on this table tend to be quite expensive).

If you all don't like this approach, that's fine, though. I figured this PR was a cheap way to get us what we needed for debugging.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Copy link
Member

@shanemcd shanemcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will eventually probably need this in its own database column, but I think this is fine for now.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants