-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record the receptor unit ID on the job record for debugging purposes #9892
record the receptor unit ID on the job record for debugging purposes #9892
Conversation
This won't be in the actual job environment, will it? |
450e71e
to
b3b7e55
Compare
I think I've confirmed that (via ansible/test-playbooks#153) My thought was that a new |
@AlanCoding it won't, no. This JSON blob was just a convenient place to store the data without having to resort to a new column on a table that tends to be very large (schema changes on this table tend to be quite expensive). If you all don't like this approach, that's fine, though. I figured this PR was a cheap way to get us what we needed for debugging. |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will eventually probably need this in its own database column, but I think this is fine for now.
b3b7e55
to
4db3c36
Compare
Build succeeded.
|
Build succeeded (gate pipeline).
|
see: #8641