Make lookup plugins return lists to fix failures #15625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:awx_collection
AlanCoding
commented
Nov 11, 2024
| host = https://localhost:8043 | ||
| verify_ssl = true | ||
| oauth_token = LEdCpKVKc4znzffcpQL5vLG8oyeku6 | ||
| ``` |
There was a problem hiding this comment.
@tvo318 You made this change to awx_collection/tools/roles/template_galaxy/templates/README.md.j2 but this file is templated from that file.
We have this duplication due to technical reasons, allowing installing from source. This is obtained from running make awx_collection_build, so I want to be super clear that this unrelated change comes from the templating.
webknjaz
reviewed
Nov 11, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
AlanCoding
requested review from
fosterseth,
TheRealHaoLiu and
chrismeyersfsu
PabloHiro
approved these changes
Nov 12, 2024
thedoubl3j
reviewed
Nov 12, 2024
chrismeyersfsu
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Trying to fix CI failures.
ISSUE TYPE
COMPONENT NAME