Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable DAB requirement #15621

Closed
wants to merge 1 commit into from

Conversation

AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Nov 7, 2024

SUMMARY

This broke stuff

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

To give info on what the resource detail view looks like:

{
    "object_id": "3",
    "name": "rando",
    "ansible_id": "bf783aba-b919-49c5-9a2b-5890a8972e9b",
    "service_id": "a4d7bb20-e593-4ad7-aa32-715a2d4dcbc1",
    "is_partially_migrated": false,
    "resource_type": "shared.user",
    "has_serializer": true,
    "resource_data": {
        "username": "rando",
        "email": "",
        "first_name": "",
        "last_name": ""
    },
    "url": "[/api/controller/v2/service-index/resources/bf783aba-b919-49c5-9a2b-5890a8972e9b/](https://localhost/api/controller/v2/service-index/resources/bf783aba-b919-49c5-9a2b-5890a8972e9b/)",
    "additional_data": {
        "social_auth": []
    }
}

Link

https://github.com/ansible/django-ansible-base/blob/f5581def9bb4e0ae58dbe77f293b74e6f8de9b44/ansible_base/resource_registry/shared_types.py#L43

so user.social_auth.all(), without this library installed, is working and correctly giving an empty list when the requirement is not installed.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

@AlanCoding
Copy link
Member Author

@djyasin is taking care of this.

@AlanCoding AlanCoding closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant